Fixed missing textures with languages like Turkish #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes cases where the default locale uses different uppercase characters as opposed to the standard english language. Example: Turkish locale uses the character 'İ' as an uppercase i.
|
Thanks! |
ata4
added a commit
that referenced
this pull request
Dec 1, 2019
Fixed missing textures with languages like Turkish
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a very weird issue, where when your pc language was set to Turkish you'd often end up with missing textures. For some reason, every texture name had all
icharacters converted to?characters.The source of the problem seems to be, that texture names are converted using
String.toLowerCase(), which uses the standard locale. If this happens to be the Turkish locale, theIcharacter is not converted toi, as you would expect from the English language, but toı. This due to the Turkish language having 2Icharacters. The "Dotted I" (U+0069) and the "Dotles I" (U+0131).I changed the toLowerCase conversion to always use the
Locale.ROOTlocale instead of the standard one.Fixes #51