Fix improper hash collision handling in WindingFactory #108
+8
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
WindingFactoryclass uses maps to cache already calculated windings.While all methods use their respective
DStructas keys in the cache,fromSide()uses a hash based on theDBrushand theDBrushSide. This approach however doesn't account for hash collisions. If aDBrush+DBrushSidecombination produces the same hash as a differentDBrush+DBrushSidecombination, the method incorrectly assumes their equal and returns the already calculated winding.The pull request fixes this by simply using a Key-Value pair class as keys in the cache.
This probably resolves #56 as it seems to have been caused by this.