Skip to content

Conversation

@AceTheCreator
Copy link
Member

@AceTheCreator AceTheCreator commented Dec 9, 2025

This PR reverts changes introduced in #2170 #2169 #2168

cc @derberg

Summary by CodeRabbit

  • Chores
    • Updated internal authentication mechanisms for event creation workflows, streamlining credential requirements and standardizing header formatting.
    • Optimized GitHub Actions configurations to enhance system security and maintainability across event scheduling processes.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Dec 9, 2025

Walkthrough

The pull request removes the ZOOM_CLIENT_ID secret from six GitHub Actions workflow files and the reusable workflow input definition, then updates the Zoom API authentication helper to use only ZOOM_TOKEN instead of both secrets. Authorization headers are simplified with lowercase content-type formatting and a User-Agent header addition.

Changes

Cohort / File(s) Summary
Event Workflow Secret Removals
.github/workflows/create-event-ad-hoc.yml, create-event-community-meeting.yml, create-event-lets-talk-about.yml, create-event-spec-3-0.yml, create-event-spec-3-docs.yml, create-event-thinking-out-loud.yml
Removed ZOOM_CLIENT_ID from secrets block in each workflow; no other changes to inputs or control flow.
Reusable Workflow
.github/workflows/create-event-workflow-reusable.yml
Removed ZOOM_CLIENT_ID from workflow inputs secrets section and environment setup; remaining secrets unchanged.
Zoom Authentication Helper
.github/workflows/create-event-helpers/zoom/index.js
Simplified token request authorization to use only ZOOM_TOKEN (removed ZOOM_CLIENT_ID combination); added User-Agent header; changed content-type to lowercase; changed Authorization scheme from Bearer to lowercase bearer.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Homogeneous changes: repetitive secret removals across multiple workflow files follow an identical pattern
  • Single logic change: authentication header simplification in one helper file is straightforward
  • Low complexity: no conditional logic, error handling, or structural modifications

Possibly related PRs

Suggested labels

ready-to-merge

Suggested reviewers

  • derberg
  • bandantonio
  • thulieblack
  • asyncapi-bot-eve

Poem

🐰 Secrets simplified, one by one,
ZOOM_CLIENT_ID's work is done!
Bearer becomes bearer, lowercase and lean,
The cleanest auth flow we've ever seen!
A helper refreshed, headers made bright,
Workflows now trimmed and perfectly right! ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'fix: revert zoom changes' clearly and accurately summarizes the primary change—reverting previous zoom-related modifications across multiple workflow files and a helper script.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
.github/workflows/create-event-helpers/zoom/index.js (1)

21-27: Confirm ZOOM_TOKEN format for Basic auth to Zoom OAuth

This now sends Authorization: Basic ${process.env.ZOOM_TOKEN} to /oauth/token. That will only work if ZOOM_TOKEN already holds the base64‑encoded clientId:clientSecret string (i.e., not the raw client ID or raw secret alone). Please confirm the secret’s format in the workflow/env docs so that future changes don’t accidentally break this flow; otherwise, you’d need to do the base64 encoding here instead of relying on the env value.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b71da37 and 26032e1.

📒 Files selected for processing (8)
  • .github/workflows/create-event-ad-hoc.yml (0 hunks)
  • .github/workflows/create-event-community-meeting.yml (0 hunks)
  • .github/workflows/create-event-helpers/zoom/index.js (2 hunks)
  • .github/workflows/create-event-lets-talk-about.yml (0 hunks)
  • .github/workflows/create-event-spec-3-0.yml (0 hunks)
  • .github/workflows/create-event-spec-3-docs.yml (0 hunks)
  • .github/workflows/create-event-thinking-out-loud.yml (0 hunks)
  • .github/workflows/create-event-workflow-reusable.yml (0 hunks)
💤 Files with no reviewable changes (7)
  • .github/workflows/create-event-spec-3-docs.yml
  • .github/workflows/create-event-ad-hoc.yml
  • .github/workflows/create-event-thinking-out-loud.yml
  • .github/workflows/create-event-community-meeting.yml
  • .github/workflows/create-event-workflow-reusable.yml
  • .github/workflows/create-event-lets-talk-about.yml
  • .github/workflows/create-event-spec-3-0.yml
🔇 Additional comments (1)
.github/workflows/create-event-helpers/zoom/index.js (1)

51-58: Header changes on meeting creation look fine; verify Zoom tolerance for bearer casing

The added User-Agent and lower‑cased content-type are harmless, and the authorization header Authorization: bearer ${token} should be acceptable because HTTP auth scheme tokens are case‑insensitive. Given this is a revert, it should match previously working behavior, but it’s worth double‑checking against current Zoom API docs or a quick manual run to ensure Zoom doesn’t have any quirks around the Bearer/bearer casing.

@AceTheCreator AceTheCreator merged commit 55d0cb1 into asyncapi:master Dec 9, 2025
21 checks passed
@derberg derberg mentioned this pull request Dec 10, 2025
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants