-
-
Notifications
You must be signed in to change notification settings - Fork 167
fix: revert zoom changes #2182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: revert zoom changes #2182
Conversation
WalkthroughThe pull request removes the Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/workflows/create-event-helpers/zoom/index.js (1)
21-27: ConfirmZOOM_TOKENformat for Basic auth to Zoom OAuthThis now sends
Authorization: Basic ${process.env.ZOOM_TOKEN}to/oauth/token. That will only work ifZOOM_TOKENalready holds the base64‑encodedclientId:clientSecretstring (i.e., not the raw client ID or raw secret alone). Please confirm the secret’s format in the workflow/env docs so that future changes don’t accidentally break this flow; otherwise, you’d need to do the base64 encoding here instead of relying on the env value.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (8)
.github/workflows/create-event-ad-hoc.yml(0 hunks).github/workflows/create-event-community-meeting.yml(0 hunks).github/workflows/create-event-helpers/zoom/index.js(2 hunks).github/workflows/create-event-lets-talk-about.yml(0 hunks).github/workflows/create-event-spec-3-0.yml(0 hunks).github/workflows/create-event-spec-3-docs.yml(0 hunks).github/workflows/create-event-thinking-out-loud.yml(0 hunks).github/workflows/create-event-workflow-reusable.yml(0 hunks)
💤 Files with no reviewable changes (7)
- .github/workflows/create-event-spec-3-docs.yml
- .github/workflows/create-event-ad-hoc.yml
- .github/workflows/create-event-thinking-out-loud.yml
- .github/workflows/create-event-community-meeting.yml
- .github/workflows/create-event-workflow-reusable.yml
- .github/workflows/create-event-lets-talk-about.yml
- .github/workflows/create-event-spec-3-0.yml
🔇 Additional comments (1)
.github/workflows/create-event-helpers/zoom/index.js (1)
51-58: Header changes on meeting creation look fine; verify Zoom tolerance forbearercasingThe added
User-Agentand lower‑casedcontent-typeare harmless, and the authorization headerAuthorization: bearer ${token}should be acceptable because HTTP auth scheme tokens are case‑insensitive. Given this is a revert, it should match previously working behavior, but it’s worth double‑checking against current Zoom API docs or a quick manual run to ensure Zoom doesn’t have any quirks around theBearer/bearercasing.
This PR reverts changes introduced in #2170 #2169 #2168
cc @derberg
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.