Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow skip and derived together to support proxy types. #1535

Merged
merged 1 commit into from
Jun 15, 2024

Conversation

PookieBuns
Copy link
Contributor

@PookieBuns PookieBuns commented Jun 8, 2024

Right now, when the field skip is enabled, derived fields all get ignored. This change aims to allow derived fields while using skip simultatenously to be able to use a proxy type for graphql queries.

Partially Fixes #1490

Note:

  • Does not provide support for complex object (IMHO I don't really see a use case for using skip on user defined resolvers since they are graphql exclusive don't have to be compatible with other structs per se)
  • Does not provide support for InputObject

@PookieBuns PookieBuns changed the title feat: Allow skip and derived together to use proxy type. feat: Allow skip and derived together to support proxy types. Jun 8, 2024
@sunli829 sunli829 merged commit c07a6bd into async-graphql:master Jun 15, 2024
7 checks passed
@sunli829
Copy link
Collaborator

thanks! 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

As using proxy type
2 participants