Support Directives on Subscriptions #1500
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffutter
force-pushed
the
support-directives-on-subscriptions
branch
from
f2ebc98
to
dfaa433
Compare
|
Do you have any idea why the pipeline checks could fail? |
jeffutter
force-pushed
the
support-directives-on-subscriptions
branch
2 times, most recently
from
8bff044
to
dd7b4ee
Compare
|
@xamgore I believe I fixed this up by updating |
xamgore
reviewed
Jun 13, 2024
This supports the same directives that are supported on Object on Subscriptions. My main use-case here is to support WunderGraph EDFS, which requires directives on Subscription fields: https://cosmo-docs.wundergraph.com/router/event-driven-federated-subscriptions-edfs
jeffutter
force-pushed
the
support-directives-on-subscriptions
branch
from
dd7b4ee
to
bffc938
Compare
|
@sunli829 would you be so kind to pay your attention here, please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This supports the same directives that are supported on Object on Subscriptions.
My main use-case here is to support WunderGraph EDFS, which requires directives on Subscription fields: https://cosmo-docs.wundergraph.com/router/event-driven-federated-subscriptions-edfs