Allow FList to store MultiPack entries
#902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pushkar-Bhuse
changed the title
MultiPack entriesFList to store MultiPack entries
Codecov Report
@@ Coverage Diff @@
## master #902 +/- ##
==========================================
- Coverage 80.91% 80.87% -0.04%
==========================================
Files 253 253
Lines 19618 19619 +1
==========================================
- Hits 15874 15867 -7
- Misses 3744 3752 +8
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
mylibrar
approved these changes
Jan 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a functionality mentioned in the comments of #900.
Description of changes
In this PR, we modify the interface of
FListto store and processMultiPackentries. Currently, these are mainly used by theMultiPackGroupentry to store group members. The way this happens is that for MultiPack entries, we store them as a tuple of thetidof the entry and thetidof theDataPackthe entry is associated with.Possible influences of this PR.
We can now store
MultiPackentries inFListnow, something that was not not possible earlier.Test Conducted
Describe what test cases are included for the PR.