Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pipeline interface refactor #140

Merged
merged 3 commits into from
Jan 29, 2020
Merged

Conversation

gpengzhi
Copy link
Collaborator

@gpengzhi gpengzhi commented Jan 29, 2020

resolve #125

@codecov
Copy link

codecov bot commented Jan 29, 2020

Codecov Report

Merging #140 into master will increase coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #140      +/-   ##
==========================================
+ Coverage   69.98%   70.04%   +0.06%     
==========================================
  Files         112      112              
  Lines        7549     7561      +12     
==========================================
+ Hits         5283     5296      +13     
+ Misses       2266     2265       -1
Impacted Files Coverage Δ
...rte/processors/base/tests/dummy_batch_processor.py 98.64% <ø> (ø) ⬆️
forte/processors/spacy_processors.py 92.98% <ø> (ø) ⬆️
forte/processors/nltk_processors.py 100% <ø> (ø) ⬆️
forte/processors/tests/nltk_processors_test.py 99.05% <100%> (ø) ⬆️
forte/__init__.py 100% <100%> (ø) ⬆️
...rocessors/base/tests/dummy_batch_processor_test.py 98.21% <100%> (ø) ⬆️
forte/base_pipeline.py 89.67% <100%> (+0.45%) ⬆️
...ta/readers/tests/multipack_sentence_reader_test.py 97.36% <100%> (ø) ⬆️
forte/data/readers/base_reader.py 88.65% <100%> (+0.23%) ⬆️
forte/processors/base/base_processor.py 96.87% <100%> (+2.58%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7c6ba8...ff98c54. Read the comment docs.

Copy link
Member

@hunterhector hunterhector left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@gpengzhi gpengzhi merged commit df39ce6 into asyml:master Jan 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reorganize core abstract function calls and simplify APIs
2 participants