Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancements in android keyboard interaction #376

Open
wants to merge 2 commits into
base: development
Choose a base branch
from

Conversation

shadow578
Copy link

this PR introduces two enhancements related to how the app interacts with the on-screen keyboard on android devices.

1. enable suggestions in form fields

currently, form fields (e.g. the title field when uploading a new document) do not show any suggestions while typing.
this means that there's no autocorrect and swipe typing is rendered completely useless.

this is caused by the FormBuilderTextField's enableSuggestions property being set to false.
since the docs don't mention a default value for this property, i'm assuming that the default is simply false.

explicitely setting enableSuggestions to true makes the suggestions work (see Fig. A), so i simply added it to all uses of the FormBuilderTextField.
This includes (but may not be limited to):

  • the 'Title' and 'File Name' fields when uploading a new document
  • the 'Title' field when editing a document
  • the 'Name' fields when creating a new correspondent, document type, or label

2. enable autofill of user credentials in login form

this one is quite simple because i've just added an AutofillGroup wrapping the FormBuilderField of the user credentials form shown when adding a new user.
This makes autofill suggestions show up on the keyboard normally (see Fig. B).

upload-doc-suggestions login-autofill-1
(Fig. A) GBoard showing suggestions for 'Title' field on document upload (Fig. B) GBoard showing autofill options on login (Bitwarden). Clicking the entry will autofill the credentials in the app.

@astubenbord
Copy link
Owner

Hi, sorry for the late reply. I'd have merged it already, but I'm currently refactoring most of the forms since they got really hard to maintain. I'll reiterate once I've completed the new forms. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants