fix: use left join when adding tables instead of inner join#3199
Merged
bsipocz merged 2 commits intoastropy:mainfrom Feb 3, 2025
Merged
fix: use left join when adding tables instead of inner join#3199bsipocz merged 2 commits intoastropy:mainfrom
bsipocz merged 2 commits intoastropy:mainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3199 +/- ##
=======================================
Coverage 68.34% 68.34%
=======================================
Files 231 231
Lines 19190 19190
=======================================
Hits 13116 13116
Misses 6074 6074 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
keflavich
approved these changes
Feb 3, 2025
Contributor
keflavich
left a comment
There was a problem hiding this comment.
Looks good technically. I have a question about how one figures out the parameter names.
d2d944b to
3e9ff61
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #3197
The behavior that people expect is not the one that we get with the default inner join:
with inner join
No measurement --> no result
with left join
No measurement --> masked data
Other changes
This PR also adds a new section in the documentation that tries to explain measurement tables in SIMBAD.