Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept MAST URIs as input to get_cloud_uris() #3193

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

snbianco
Copy link
Contributor

@snbianco snbianco commented Jan 28, 2025

This PR does the following:

  • Allows users to input a MAST URI string as input for Observations.get_cloud_uri.
  • Allows users to input a list of MAST URI strings as input for Observations.get_cloud_uris. Logs a warning if the user tries to provide filter criteria as well, since this won't be possible without a Table.
  • Bugfix where users where unnecessarily warned about a query result limit while trying to fetch products in MastMissions.
  • Bugfix where the functions to get cloud URIs fail if the MAST relative path cannot be returned. Now, it logs a warning and skips that particular data product.
  • Added JWST to the list of cloud-hosted missions.
  • Added both non-remote and remote test cases to increase coverage.

Copy link

codecov bot commented Jan 28, 2025

Codecov Report

Attention: Patch coverage is 96.15385% with 1 line in your changes missing coverage. Please review.

Project coverage is 68.72%. Comparing base (46ca592) to head (01c38df).
Report is 13 commits behind head on main.

Files with missing lines Patch % Lines
astroquery/mast/cloud.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3193      +/-   ##
==========================================
+ Coverage   68.18%   68.72%   +0.54%     
==========================================
  Files         231      231              
  Lines       19048    19201     +153     
==========================================
+ Hits        12987    13196     +209     
+ Misses       6061     6005      -56     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@snbianco snbianco marked this pull request as ready for review January 29, 2025 19:22
@snbianco snbianco requested a review from bsipocz January 29, 2025 19:22
@snbianco
Copy link
Contributor Author

Tagging @bmorris3 and @dr-rodriguez for visibility

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant