NIST Vectorizing#2678
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2678 +/- ##
=======================================
Coverage ? 65.74%
=======================================
Files ? 233
Lines ? 17842
Branches ? 0
=======================================
Hits ? 11731
Misses ? 6111
Partials ? 0
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
982ebda to
41d6b81
Compare
eerovaher
reviewed
Mar 16, 2023
nkphysics
commented
Mar 16, 2023
eerovaher
reviewed
Mar 16, 2023
41d6b81 to
5db02f8
Compare
nkphysics
commented
Mar 16, 2023
Member
Author
|
Looking at other PRs figured this might need a changelog entry, so I've gone ahead and added one just in case. |
eerovaher
reviewed
Mar 31, 2023
9804577 to
619798c
Compare
bsipocz
approved these changes
Mar 31, 2023
bsipocz
left a comment
Member
There was a problem hiding this comment.
All looks good, thank you!
I've also reworded the docs around the multiple lines.
Member
|
Thanks @nkphysics! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Is this what yall had in mind for #682 ?
I'm not too sure since I can't access the fb post.
Tried to explore what Vizier was doing.
Figured I'd try to start off small (why I chose NIST).
These changes allow for querying multiple linenames with one request i.e...
There might be more that could be done for NIST but
linenamewas the main place I thought this could be applied.Maybe could also be applied to
energy_level_unit, idk though that might make the responses messy.