-
-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NIST Vectorizing #2678
NIST Vectorizing #2678
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2678 +/- ##
=======================================
Coverage ? 65.74%
=======================================
Files ? 233
Lines ? 17842
Branches ? 0
=======================================
Hits ? 11731
Misses ? 6111
Partials ? 0
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
982ebda
to
41d6b81
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
41d6b81
to
5db02f8
Compare
Looking at other PRs figured this might need a changelog entry, so I've gone ahead and added one just in case. |
9804577
to
619798c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good, thank you!
I've also reworded the docs around the multiple lines.
Thanks @nkphysics! |
Is this what yall had in mind for #682 ?
I'm not too sure since I can't access the fb post.
Tried to explore what Vizier was doing.
Figured I'd try to start off small (why I chose NIST).
These changes allow for querying multiple linenames with one request i.e...
There might be more that could be done for NIST but
linename
was the main place I thought this could be applied.Maybe could also be applied to
energy_level_unit
, idk though that might make the responses messy.