Skip to content

Skip redshift test cases in CI #1975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 23, 2023
Merged

Skip redshift test cases in CI #1975

merged 2 commits into from
Jun 23, 2023

Conversation

utkarsharma2
Copy link
Contributor

There is an upstream issue for redshift cluster type - dc2
Error:

`UnicodeDecodeError: 'utf-8' codec can't decode byte 0xf0 in position 122: unexpected end of data` Can you please explain why is that the case?

ref - https://github.com/astronomer/astro-sdk/actions/runs/5355001227/jobs/9712737921?pr=1974

Case created with AWS: https://support.console.aws.amazon.com/support/home?region=us-east-2#/case/?displayId=12988936661&language=en

Awaiting response till then we are skipping the tests

@tatiana
Copy link
Collaborator

tatiana commented Jun 23, 2023

Thank you very much, @utkarsharma2 , for looking into this!

@codecov
Copy link

codecov bot commented Jun 23, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.33 ⚠️

Comparison is base (722b972) 91.64% compared to head (918459a) 91.31%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1975      +/-   ##
==========================================
- Coverage   91.64%   91.31%   -0.33%     
==========================================
  Files          72       72              
  Lines        4250     4250              
  Branches      511      511              
==========================================
- Hits         3895     3881      -14     
- Misses        258      282      +24     
+ Partials       97       87      -10     
Flag Coverage Δ
PythonSDK 91.31% <ø> (-0.33%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 8 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@tatiana tatiana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@utkarsharma2, do we have a follow-up Github ticket for us to undo these changes once we have a reply from Redshift?

@utkarsharma2
Copy link
Contributor Author

There you go - #1976

@utkarsharma2 utkarsharma2 merged commit e07a0ed into main Jun 23, 2023
@utkarsharma2 utkarsharma2 deleted the SkipRedshift branch June 23, 2023 13:22
utkarsharma2 added a commit that referenced this pull request Aug 8, 2023
There is an upstream issue for redshift cluster type - `dc2`
Error:
```
`UnicodeDecodeError: 'utf-8' codec can't decode byte 0xf0 in position 122: unexpected end of data` Can you please explain why is that the case?
```
ref -
https://github.com/astronomer/astro-sdk/actions/runs/5355001227/jobs/9712737921?pr=1974

Case created with AWS:
https://support.console.aws.amazon.com/support/home?region=us-east-2#/case/?displayId=12988936661&language=en

Awaiting response till then we are skipping the tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants