feat: Trusted auctioneer: Maintain a separate optimistic block fork #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bharath-123
changed the title
bharath-123
changed the title
bharath-123
changed the title
bharath-123
changed the title
bharath-123
changed the title
bharath-123
commented
Sep 27, 2024
grpc/execution/server.go
Outdated
| @@ -231,6 +235,89 @@ func protoU128ToBigInt(u128 *primitivev1.Uint128) *big.Int { | |||
| return lo.Add(lo, hi) | |||
| } | |||
|
|
|||
| func (s *ExecutionServiceServerV1Alpha2) ExecuteOptimisticBlock(ctx context.Context, req *optimsticPb.BaseBlock) (*astriaPb.Block, error) { | |||
There was a problem hiding this comment.
This will be used in the streamExecuteOptimisticBlock grpc and we will move it out to its own package when we implement the grpc method.
bharath-123
requested review from
joroshiba,
mycodecrafting and
noot
as code owners
bharath-123
commented
Oct 7, 2024
| currentSnapBlock atomic.Pointer[types.Header] // Current head of snap-sync | ||
| currentFinalBlock atomic.Pointer[types.Header] // Latest (consensus) finalized block | ||
| currentSafeBlock atomic.Pointer[types.Header] // Latest (consensus) safe block | ||
| currentBlock atomic.Pointer[types.Header] // Current head of the chain |
There was a problem hiding this comment.
We can use this instead of maintaining a separate currentOptimisticBlock
bharath-123
commented
Oct 7, 2024
grpc/execution/server.go
Outdated
| } | ||
|
|
||
| // Build a payload to add to the chain | ||
| payloadAttributes := &miner.BuildPayloadArgs{ |
There was a problem hiding this comment.
we would want to validate the transactions before executing them. It might be cheaper than executing the transaction on a VM.
bharath-123
force-pushed
the
bharath/implement-optimistic-fork-creation
branch
from
267d68a to
e786668
Compare
bharath-123
force-pushed
the
bharath/implement-optimistic-fork-creation
branch
from
eb28e72 to
c925895
Compare
bharath-123
force-pushed
the
bharath/implement-optimistic-fork-creation
branch
from
c85c783 to
fe03e69
Compare
bharath-123
force-pushed
the
bharath/implement-optimistic-fork-creation
branch
from
fe03e69 to
9f7886f
Compare
chore: Trusted Auctioneer: update the protos
feat: Trusted Auctioneer: Add initial set of metrics for auctioneer
feat: Trusted Auctioneer: Code cleanups
…-block feat: Trusted Auctioneer: Add API to query the current optimistic block
feat: Trusted Auctioneer: Support unmarshalling signed allocations and placing it at the TOB
feat: Trusted Auctioneer: Add a cmd line flag to run a Flame node in auctioneer mode
refactor: Trusted Auctioneer: Separate execution api service and optimistic execution api service
feat: Trusted Auctioneer: Implement bundle streaming
…ecution feat: Trusted Auctioneer: implement stream execute optimistic block
feat: Trusted Auctioneer: add event which is triggered when the mempool is cleared
feat: Trusted Auctioneer: Clear mempool when mempool state is reset
feat: Trusted auctioneer: use optimistic head event in txpool's maintanance loop
…k-event feat: Trusted auctioneer: Add an event for optimistic head creation
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the trusted auctioneer, we want to maintain two separate forks of the Flame chain:
StreamOptimisticBlockgrpc method.This PR adds support for maintaining an optimistic fork given a
BaseBlockstruct which will be received by the Flame trusted auctioneer via theStreamOptimisticBlockstream.The following changes have been made:
ExecuteOptimisticBlockwhich takes in aBaseBlockstruct and creates an optimistic block which is inserted into the chain.currentOptimisticBlockpointer incore.Blockchainwhich stores a pointer to the header of the current optimistic block. This pointer is updated after an optimistic block is successfully executed inExecuteOptimisticBlockBuildPayloadArgstakes an extra parameter calledoverrideTransactionswhich is a list of transactions which will be executed overAstriaOrdered. This will be simpler rather than maintaining a separate mempool list likeAstriaOrderedfor optimistic block transactions. When we are executing the optimistic block we override theoverrideTransactionslist with the list of transactions in our optimistic block. It does not matter to us if the transactions do not execute as they will be removed from the mempool as this block is eventually executed by conductor.IsOptimisticExecutionflag during payload building. If this flag is true, reverting transactions are not removed from the mempool.ExecuteOptimisticBlockNote: If there are transactions which revert during optimistic execution, we do not care about removing them since they would eventually be removed during the actual block execution which would be done by conductor.