feat: error on non-existent extra from lock file #10925
Draft
+312
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkniewallner
commented
Jan 24, 2025
| @@ -625,6 +625,11 @@ impl Lock { | |||
| }) | |||
| } | |||
|
|
|||
| /// Returns the package whose name matches [`PackageName`]. | |||
| pub fn find_package(&self, name: &PackageName) -> Option<&Package> { | |||
There was a problem hiding this comment.
We could make it find_packages instead to iterate once and retrieve the packages we are interested in.
Comment on lines
+152
to
+156
| #[error("Extra `{0}` is not defined in the project's `optional-dependencies` table")] | ||
| MissingExtraProject(ExtraName), | ||
|
|
||
| #[error("Extra `{0}` is not defined in any project's `optional-dependencies` table")] | ||
| MissingExtraWorkspace(ExtraName), |
There was a problem hiding this comment.
Wording could probably be adapted here, as the check happens at lock file level, but not sure exactly how we would want to phrase this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Alternative to #10869 which follows the suggestion, in #10869 (comment), to validate extras from the lock file instead of
pyproject.toml.Test Plan
Snapshot tests.