Error when workspace contains conflicting Python requirements #10841
+109
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
commented
Jan 22, 2025
| .as_ref() | ||
| .map(find_requires_python) | ||
| .transpose()? | ||
| .flatten() |
There was a problem hiding this comment.
This is kind of gross, but struggling to improve it.
charliermarsh
commented
Jan 22, 2025
| .map(VersionSpecifiers::clone) | ||
| .collect::<BTreeSet<_>>(); | ||
| Err(ProjectError::DisjointRequiresPython( | ||
| specifiers.into_iter().collect(), |
There was a problem hiding this comment.
This just includes all of the specifiers.
zanieb
approved these changes
Jan 22, 2025
zanieb
reviewed
Jan 22, 2025
| ----- stdout ----- | ||
|
|
||
| ----- stderr ----- | ||
| error: The workspace contains conflicting Python requirements: `==3.10`, `>=3.12` |
There was a problem hiding this comment.
It'd be ideal to include sources here, if feasible. Perhaps as a future change.
Maybe like
error: The workspace contains conflicting Python requirements:
- project: `>=3.12`
- child: `==3.10`
konstin
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
If members define disjoint Python requirements, we should error. Right now, it seems that it maps to unbounded and leads to weird behavior.
Closes #10835.