Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update smoke test scripts to fail on first error #10831

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update smoke test scripts to fail on first error #10831

wants to merge 2 commits into from
+8 −0

Conversation

zanieb
Copy link
Member

@zanieb zanieb commented Jan 21, 2025 •
edited
Loading

Right now, these just continue on failure?

@zanieb zanieb added the testing Internal testing of behavior label Jan 21, 2025
@zanieb zanieb marked this pull request as ready for review January 21, 2025 22:58
@zanieb zanieb deployed to uv-test-publish January 22, 2025 03:17 — with GitHub Actions Active
konstin
konstin approved these changes Jan 22, 2025
View reviewed changes
Copy link
Member

@konstin konstin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@konstin konstin konstin approved these changes

Assignees
No one assigned
Labels
testing Internal testing of behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zanieb @konstin