Add a lock target abstraction #10129
Draft
+311
−189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
added
no-build
charliermarsh
force-pushed
the
charlie/installable
branch
from
cef42c0 to
3e31c52
Compare
charliermarsh
force-pushed
the
charlie/lock-target
branch
from
0487793 to
c382f2f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces a
LockTarget, which is peer toInstallTargetand enables us to capture the common functionality necessary to support locking.For now, to minimize changes, only the
Workspacetarget is implemented. In a future PR, I'll add aScripttarget for both locking and installing.