Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install different versions of Runkit(7) based on the PHP version #20

Merged
merged 2 commits into from
Nov 24, 2020

Conversation

stevegrunwell
Copy link
Member

@stevegrunwell stevegrunwell commented Nov 24, 2020

The runkit7 PECL package wasn't getting installed for PHP 7.0 or 7.1, as they're no longer supported by the latest releases of runkit7.

This PR splits out the PHP setup jobs for PHP 5.6–7.1, though we can't easily get a version of runkit7 that works with PHP 7.0 via PECL (see #21).

@stevegrunwell stevegrunwell added the code quality Improve the quality of the codebase label Nov 24, 2020
@stevegrunwell stevegrunwell added this to the Version 0.2.0 milestone Nov 24, 2020
@stevegrunwell stevegrunwell self-assigned this Nov 24, 2020
@stevegrunwell stevegrunwell force-pushed the fix/runkit-install-on-older-php7 branch from 61d912d to 699b889 Compare November 24, 2020 03:10
@stevegrunwell stevegrunwell merged commit 8a1c8ed into develop Nov 24, 2020
@stevegrunwell stevegrunwell deleted the fix/runkit-install-on-older-php7 branch November 24, 2020 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality Improve the quality of the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant