-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow developer to set a custom web socket url #111
base: main
Are you sure you want to change the base?
Conversation
- Default behavior does not break current usages - Default behavior allows more usages whose URL ends with "/mirrorsharp" - When a WebSocketUrl is set, that is used - We are lenient with the case of the URL - We are lenient with leading or following spaces
Thanks for this! I think the goal definitely makes sense. I would be keen to investigate a bit further on the new endpoint routing -- seems like something we could use here? Not sure yet, haven't tried it myself. |
Summary path change -> the 'wss:/' part is not necessary
I have investigated the endpoint routing a bit, and I think we don't have to handle the URL manually. What we could do instead is:
app.Map("/mirrorsharp", app => app.UseMirrorSharp()); Obviously we want people to avoid mistakes, so I would actually obsolete
app.UseEndpoints(endpoints =>
{
endpoints.Map("/mirrorsharp", endpoints.CreateApplicationBuilder()
.UseMirrorSharp()
.Build());
}); This is obviously too verbose, so providing another So, in summary, I suggest the following:
|
[ISSUE] #110