Skip to content

Add issuer as an initialization parameter #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

pavinduLakshan
Copy link
Contributor

Purpose

$subject

Related Issues

Related PRs

  • N/A

Checklist

  • Manual test round performed and verified.
  • Documentation provided.
  • Unit tests provided.

Security checks

@@ -11,6 +11,7 @@ const port = process.env.PORT || 3000;

const mcpAuthServer = new McpAuthServer({
baseUrl: process.env.BASE_URL as string,
issuer: process.env.ISSUER as string,
Copy link
Member

@brionmario brionmario Jun 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we make this mandatory?

IMO, we can default to inferring the base part from baseUrl and let the users override the issuer endpoint as an optional thing?

const mcpAuthServer = new McpAuthServer({
  baseUrl: process.env.BASE_URL as string,
  endpoints: { -> // optional
      issuer: process.env.ISSUER as string,
  }
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants