-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate the default sample to vite #259
Open
HewageNKM
wants to merge
16
commits into
asgardeo:main
Choose a base branch
from
HewageNKM:Migrate-the-default-Sample-to-Vite
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Migrate the default sample to vite #259
HewageNKM
wants to merge
16
commits into
asgardeo:main
from
HewageNKM:Migrate-the-default-Sample-to-Vite
+31,717
−428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…te' into Migrate-the-default-Sample-to-Vite # Conflicts: # samples/asgardeo-vite-app/README.md # samples/asgardeo-vite-app/eslint.config.js # samples/asgardeo-vite-app/index.html # samples/asgardeo-vite-app/package.json # samples/asgardeo-vite-app/src/main.jsx # samples/asgardeo-vite-app/tsconfig.json # samples/asgardeo-vite-app/vite.config.js
HewageNKM
requested review from
brionmario,
NipuniBhagya,
inthirakumaaran and
jeradrutnam
as code owners
October 24, 2024 07:07
Co-authored-by: Pavindu Lakshan <[email protected]>
Co-authored-by: Pavindu Lakshan <[email protected]>
Co-authored-by: Pavindu Lakshan <[email protected]>
Co-authored-by: Pavindu Lakshan <[email protected]>
Hi @HewageNKM, Lets keep the PR template since it contains some mandatory checks and sections :) |
@brionmario working on them |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#258 Completely migrate old WebPack to the new Vite template
#Hacktoberfest
Kindly Review
@brionmario
@pavinduLakshan
@NipuniBhagya
@jeradrutnam