Skip to content

Fix some bugs with multiple screens #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dacap merged 4 commits into from
Nov 10, 2025
Merged

Fix some bugs with multiple screens #164

dacap merged 4 commits into from
Nov 10, 2025

Conversation

@dacap
Copy link
Member

@dacap dacap commented Nov 8, 2025 •
edited
Loading

  • Refactor to avoid using [NSScreen mainScreen] as the primary screen which is NSScreen.screens[0] in fact
  • The absolute mouse position should be relative to the primary screen, reverts 6dacf91 in some way, but to pick a color from the screen we'll have to use an absolute mouse position relative to the primary screen (no to the main screen which varies on macOS depending on the keyboard focus)
  • Fixes [osx] Fix creation of windows in a specific location w/multiple screens #162

@dacap
Refactor os::Screen::isMainScreen() -> isPrimary()
25b6135 
To avoid confusion with the [NSScreen mainScreen] concept which is the
screen containing the active keyboard focused window.
@dacap dacap self-assigned this Nov 8, 2025
@dacap
Add os::System::handleWindowMoving callback
779f5a6 
We can detect when the mouse is being moved by the user in case that
we want to update something (e.g. the window coordinates) in the
client area (multiple_windows example does this).
@dacap dacap force-pushed the fix-multiple-screens branch from 5235371 to 779f5a6 Compare November 10, 2025 14:20
dacap added 2 commits November 10, 2025 12:08
@dacap
Minor changes in multiple_windows example
9a8fe27 
* Simplify code to locate the each window
* Added possibility to resize a window w/shift+arrow keys
@dacap
[osx] Fix Window::frame/contentFrame locations for multiple screens (fix
25d60a2 
 aseprite#162)
@dacap
Copy link
Member Author

dacap commented Nov 10, 2025 •
edited
Loading

Before:

Screenshot 2025-11-10 at 12 09 53 PM

After 25d60a2:

Screenshot 2025-11-10 at 11 58 47 AM

The "H" window is not located correctly because it looks like a macOS bound check in the initialization of a new app to avoid overlapping the dock (even if the window is not close to the dock at all).

@dacap dacap marked this pull request as ready for review November 10, 2025 15:13
@dacap dacap merged commit 25d60a2 into aseprite:main Nov 10, 2025
12 checks passed
@dacap dacap deleted the fix-multiple-screens branch November 10, 2025 19:34
dacap added a commit to dacap/aseprite that referenced this pull request Nov 10, 2025
@dacap
Update laf module (fix aseprite/laf#164)
3c23fb4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@dacap dacap

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[osx] Fix creation of windows in a specific location w/multiple screens

1 participant

@dacap