Fix drop pixels when drag/modifying tag range while transform state is active (fiix #4375) #4418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s active (fiix aseprite#4375) Before this fix, aseprite displayed an error message instead of dropping pixels.
|
clang-tidy review says "All clean, LGTM! 👍" |
| if (m_editor) { | ||
| if (auto movingPixels = dynamic_cast<MovingPixelsState*>(m_editor->getState().get())) | ||
| movingPixels->onDropPixels(ContextBarObserver::DropPixels); | ||
| } |
There was a problem hiding this comment.
Works as expected. Just want to share some thoughts about this:
I like that all the code is here in one place, but I wonder what should we do if another widget/component needs to be aware of the tag resizing of the timeline, should we keep adding code here as well? This led me to think that an event/observer based approach might have been a good fit for this fix, but it would have been more complex to implement...so I'm not sure it worth it, also because I think that the timeline is going to be reimplemented or something. So maybe we shouldn't worry about this right now, and just refactor if the need arises in the future.
martincapello
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this fix, aseprite displayed an error message instead of dropping pixels.
Issue #4375 was originally due to a crash when dragging a tag while the transformation was active. But it was fixed via 7905acf (related to #4367), then the original action resulted in an error message, additionally canceling the dragging of the label range.
fix #4375