Update groups metadata #51
Conversation
asclepias_broker/admin.py
Outdated
| update_metadata_form = UpdateMetadataForm() | ||
| message = None | ||
| if update_metadata_form.validate_on_submit(): | ||
| dir_path = request.form['dir_path'] |
There was a problem hiding this comment.
The issue with this is that the path that is passed might not be available on the server (this is especially true for e.g. OpenShift applications which are just running in a docker container), unless it's some kind of network mount which would always be there consistently.
What would rather make sense is uploading a zip/tar, though this might complicate things a bit for this admin view.
I would say let's create an issue for the Admin-UI where we can keep track of this and other useful views we can add in the future.
There was a problem hiding this comment.
You're right, I didn't think about it!
I created an issue here: #53
asclepias_broker/cli.py
Outdated
| EventAPI.handle_event(event, no_index=True, delayed=False) | ||
| except ValueError: | ||
| pass | ||
| update_group_metadata(identifiers[0], data.get('Object')) |
There was a problem hiding this comment.
I think you have to do a db.session.commit() at the end of this function to seal the deal (this might also be the reason why the single-payload-update you mentioned didn't work).
| @@ -64,6 +65,80 @@ def off_test_simple_id_group_merge(db): | |||
| assert Identifier2Group.query.count() == 5 | |||
|
|
|||
|
|
|||
| def test_update_groups(db): | |||
There was a problem hiding this comment.
This test might be a better fit for test_metadata.py (or test_cli.py). We'll have to restructure tests in general though, so let's make an issue instead.
There was a problem hiding this comment.
I created this issue: #52
ChiaraBi
force-pushed
the
update_metadata
branch
2 times, most recently
from
fb19d25 to
aa5a335
Compare
asclepias_broker/api/ingestion.py
Outdated
| @@ -452,3 +452,11 @@ def update_metadata(relationship: Relationship, payload): | |||
| rel_metadata.update( | |||
| {k: v for k, v in payload.items() | |||
| if k in ('LinkPublicationDate', 'LinkProvider')}) | |||
|
|
|||
|
|
|||
| def update_group_metadata(identifier, payload): | |||
There was a problem hiding this comment.
It's better to use simple/primitive values as parameters to functions, and in this case identifiers is a dictionary with a specific format, which means that you would have to document it.
Maybe it's better to have something like def update_group_metadata(id_value, id_scheme, payload):
No description provided.