Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for SendGrid API #274

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ravinggenius
Copy link

We need SendGrid API support at work, so I added it.

@soupli
Copy link

soupli commented Oct 16, 2020

Could this be looked into? As this will begin to be required for SendGrid users as of October 31st, 2020. Thanks

@aschroder

@devaliere
Copy link

Also need this feature, somebody did a fix on that ?

@soupli
Copy link

soupli commented Nov 20, 2020

Also need this feature, somebody did a fix on that ?

You could simply use the branch that @ravinggenius pushed

ravinggenius:support-sendgrid-api

I do not think this will ever be merged, cause there is no support for this module anymore

@devaliere
Copy link

Thank you @soupli.
I add all the file, just don't know how to install (and where) the sendgrid API.
Any idea, advice ?

@ravinggenius
Copy link
Author

You should be able to install my fork if you have Composer. Something like (not tested):

composer config repositories.repo-name vcs https://github.com/ravinggenius/Magento-SMTP-Pro-Email-Extension.git
composer require aschroder/smtp_pro:dev-support-sendgrid-api --prefer-source

SEE https://webkul.com/blog/install-packages-using-composer-local-git-repo/
SEE https://marekkalnik.tumblr.com/post/22929686367/composer-installing-package-from-local-git

@gcharpentier591
Copy link

Hello @devaliere have you found where to integrate the sendgrid lib?

@devaliere
Copy link

@gcharpentier591 : I am not able to make it working. I install it (manually through git clone and then composer install) and then choose Sengrid APi (and copy my API) but the test mail is not working so I am block on this issue (unfortunately :()

@earwickerh
Copy link

earwickerh commented May 12, 2021

Thanks @ravinggenius! The self-test doesn't run when using the SendGrid API option. Also noticed there's only a field for API key (no "User" or "API key ID field") since self-test wasn't running, not sure if it's working. Just realized @devaliere had the same issue.

@ravinggenius
Copy link
Author

@earwickerh it worked for me when I wrote it originally. Please feel free to add to what I have here or even open a new merge request. I no longer work for the company I did when I opened this merge request, and I have no need for Magento, Sendgrid or even PHP in my current role.

I'm not trying to leave anyone hanging, but I cannot offer any support beyond what I have already done in this merge request.

@ProxiBlue
Copy link

worked fine for me, thank you for this effort @ravinggenius

FYI, I published a new version/release on version 2.1.0 on a fork, and placed it in on repman.io for composer install

composer config --global --auth http-basic.github.repo.repman.io token ec42f7dd9269f0d9355f94279d221d3f07c4f8c70c9344a1ef27ddbc0a07a8d6

Add these lines to your composer.json file, or add a new repository URL if you already have one or more:

{
    "repositories": [
        {"type": "composer", "url": "https://github.repo.repman.io"}
    ]
}

and then use composer require aschroder/smtp_pro

make sure you first remove any local installed packages under app/etc/local

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants