Add Gemini LLM and Summarizer #1176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karanataryn
changed the title
HenryL27
approved these changes
Feb 14, 2025
HenryL27
approved these changes
Feb 14, 2025
| @@ -81,6 +82,23 @@ def __init__(self, llm: LLM, prompt: Optional[str] = None, include_context: bool | |||
| self.prompt = prompt | |||
| self.include_context = include_context | |||
|
|
|||
| def summarize_image(self, image: Image.Image, context: Optional[str]) -> str: | |||
There was a problem hiding this comment.
what do you think about "context" -> "system" ? idk.
There was a problem hiding this comment.
I like context for now, we can change later based on usage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces support for the Google Gemini language model in the Sycamore project. The changes include adding the necessary dependencies, integrating the Gemini model, adding it as a summarizer, and implementing unit tests to ensure its functionality.