Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update documentation #1867

Merged
merged 32 commits into from
Feb 1, 2025
Merged

Update documentation #1867

merged 32 commits into from
Feb 1, 2025

Conversation

RickBarretto
Copy link
Collaborator

Type of change

  • Code cleanup
  • Unit tests (added or updated unit-tests)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (implementation update, or general performance enhancements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (documentation-related additions)

@github-actions github-actions bot added library Issues related to the standard library → Arithmetic → Collections → Net labels Jan 22, 2025
@drkameleon
Copy link
Collaborator

I love what you're doing here! 😃

P.S. Don't bother (too much) with as & from as... as I have said, I consider them too messy and probably scheduled for cleanup or deletion. But other than that: just go for it! Awesome job! 🚀

@RickBarretto RickBarretto mentioned this pull request Jan 23, 2025
Closed
This was linked to issues Jan 23, 2025
[Core\export] add documentation example #1621
Closed
[Core\module] add documentation example #1622
Closed
@RickBarretto
Copy link
Collaborator Author

Ok, I think it's done! 😉

drkameleon
drkameleon requested changes Jan 30, 2025
View reviewed changes
Copy link
Collaborator

@drkameleon drkameleon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow. OK. That's something!!

Great job! ❤️ (Should I even mention it?!)

Wow. Keep going, very valuable PR! 😉

P.S. If you agree, just a tiny fix that I marked above...and I'm merging! 🚀

@RickBarretto
Copy link
Collaborator Author

Updated! 😉

drkameleon
drkameleon approved these changes Feb 1, 2025
View reviewed changes
Copy link
Collaborator

@drkameleon drkameleon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!!!

Let's get it in! 😉

@drkameleon
Copy link
Collaborator

Ready to merge! 🚀

@drkameleon drkameleon merged commit 6f10987 into arturo-lang:master Feb 1, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drkameleon drkameleon drkameleon approved these changes

Assignees
No one assigned
Labels
→ Arithmetic → Collections → Colors → Converters → Core library Issues related to the standard library → Net → Strings → System → Types
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Core\module] add documentation example [Core\export] add documentation example
2 participants
@RickBarretto @drkameleon