Change IBAN format for IS (Iceland) (fixes #132) #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@arturmkrtchyan could you please take a look at this pull request? Any feedback is welcome! |
|
@proshin-roman I will approve your current PR. For the future please create a separate PR for the formatting and the cleanups. |
|
@hajk1 thank you for the approval! You mean two pull requests for the same issue, right? Will do that in the future 👍 |
|
@proshin-roman refactoring other parts of the code is a good practice and must be followed on a usual basis. However, mixing the improvements with the other fixes or features makes the review hard. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main change in this pull request is the new IBAN format for IS country code (Iceland). All the rest is more like a code clean up - I hope you don't mind. If these changes are not wanted - I can rollback them.