Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

some refactoring #129

Merged
merged 1 commit into from
Feb 19, 2024
Merged

some refactoring #129

merged 1 commit into from
Feb 19, 2024

Conversation

hajk1
Copy link
Collaborator

@hajk1 hajk1 commented Feb 13, 2024

No description provided.

@github-actions GitHub Actions
Copy link

Test Results

743 tests  ±0   741 ✅ ±0   0s ⏱️ ±0s
 16 suites ±0     2 💤 ±0 
 16 files   ±0     0 ❌ ±0 

Results for commit 8f914e7. ± Comparison against base commit b0623d9.

This pull request removes 11 and adds 11 tests. Note that renamed tests count towards both. 
org.iban4j.BicUtilTest$InvalidBicValidationTest ‑ bicValidationWithAlphanumericBankCode
org.iban4j.BicUtilTest$InvalidBicValidationTest ‑ bicValidationWithEmptyStringShouldThrowException
org.iban4j.BicUtilTest$InvalidBicValidationTest ‑ bicValidationWithInvalidBankCodeShouldThrowException
org.iban4j.BicUtilTest$InvalidBicValidationTest ‑ bicValidationWithInvalidBranchCodeShouldThrowException
org.iban4j.BicUtilTest$InvalidBicValidationTest ‑ bicValidationWithInvalidCountryCodeShouldThrowException
org.iban4j.BicUtilTest$InvalidBicValidationTest ‑ bicValidationWithInvalidLocationCodeShouldThrowException
org.iban4j.BicUtilTest$InvalidBicValidationTest ‑ bicValidationWithLessCharactersShouldThrowException
org.iban4j.BicUtilTest$InvalidBicValidationTest ‑ bicValidationWithLowercaseShouldThrowException
org.iban4j.BicUtilTest$InvalidBicValidationTest ‑ bicValidationWithMoreCharactersShouldThrowException
org.iban4j.BicUtilTest$InvalidBicValidationTest ‑ bicValidationWithNonExistingCountryCodeShouldThrowException
…

org.iban4j.BicUtilTest ‑ bicValidationWithAlphanumericBankCode
org.iban4j.BicUtilTest ‑ bicValidationWithEmptyStringShouldThrowException
org.iban4j.BicUtilTest ‑ bicValidationWithInvalidBankCodeShouldThrowException
org.iban4j.BicUtilTest ‑ bicValidationWithInvalidBranchCodeShouldThrowException
org.iban4j.BicUtilTest ‑ bicValidationWithInvalidCountryCodeShouldThrowException
org.iban4j.BicUtilTest ‑ bicValidationWithInvalidLocationCodeShouldThrowException
org.iban4j.BicUtilTest ‑ bicValidationWithLessCharactersShouldThrowException
org.iban4j.BicUtilTest ‑ bicValidationWithLowercaseShouldThrowException
org.iban4j.BicUtilTest ‑ bicValidationWithMoreCharactersShouldThrowException
org.iban4j.BicUtilTest ‑ bicValidationWithNonExistingCountryCodeShouldThrowException
…

@hajk1 hajk1 merged commit fbac1dd into master Feb 19, 2024
2 checks passed
@hajk1 hajk1 deleted the refactor/fix-test-cases branch February 19, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hajk1