feat(ONYX-902): remove contact information step #13885
Conversation
tam-kis
force-pushed
the
tam-kis/ONYX-902-remove-contact-information-step
branch
from
73bb23f
to
53521fc
Compare
tam-kis
changed the title
tam-kis
force-pushed
the
tam-kis/ONYX-902-remove-contact-information-step
branch
from
6dae6f0
to
f268d3c
Compare
| let backTo = defaultBackLink | ||
| if (isFirstStep && artworkId) { |
There was a problem hiding this comment.
Don't we still need this logic even if we change the first step? Because the first step is still there 🤔
There was a problem hiding this comment.
This is related to the back button which we don't have anymore on the first step (Artwork Details)
| @@ -365,5 +362,15 @@ export const ArtworkDetailsFragmentContainer = createFragmentContainer( | |||
| provenance | |||
| } | |||
| `, | |||
| me: graphql` | |||
|
Is this ready to be merged? |
There was a problem hiding this comment.
Is this ready to be merged?
Overall, this looks good. There is just this open question from the last review.
It seems that this wasn't merged because in the meantime there was a decision to bring back the phone number field. |
|
@tam-kis - minor, but would you mind updating the PR title to proper semantic-commit idioms? ie, |
Oh, didn't notice, strange! Thank you, will change it. |
tam-kis
changed the title
The type of this PR is: Feat
This PR solves ONYX-902
Description
Remove ContactInformation step from submission flow, update routing and steps.
Save User data: name, email and phone.
Screen.Recording.2024-05-16.at.18.01.05.mov