feat: Add My Collection artwork form location autocomplete #10227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olerichter00
changed the title
olerichter00
changed the title
olerichter00
force-pushed
the
olerichter00/ONYX-860/my-collection-form-location-autocomplete
branch
from
4d82b09
to
1014a0a
Compare
olerichter00
commented
May 21, 2024
| @@ -232,6 +232,12 @@ export const ArtworkMetaProps = graphql` | |||
| } | |||
| artistNames | |||
| category | |||
| collectorLocation { | |||
There was a problem hiding this comment.
TODO: Remove artworkLocation from the query.
damassi
reviewed
May 23, 2024
| @@ -313,6 +315,7 @@ export const MyCollectionArtworkFormMain: React.FC< | |||
| <Flex p={2}> | |||
| <Join separator={<Spacer y={2} />}> | |||
| <ArtistField /> | |||
|
|
|||
olerichter00
force-pushed
the
olerichter00/ONYX-860/my-collection-form-location-autocomplete
branch
from
4b0bbf1
to
efd7868
Compare
MounirDhahri
approved these changes
May 24, 2024
olerichter00
deleted the
olerichter00/ONYX-860/my-collection-form-location-autocomplete
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃敶 Do not merge before https://github.com/artsy/gravity/pull/17722 has run
This PR resolves ONYX-860
Description
This replaces the My Collection form location input component with a new autocomplete input component.
It is still possible to not select any of the suggestions and store an arbitrary string as a location. This string then gets saved as the "city", which can be displayed correctly in the web and app.
PR Checklist
To the reviewers 馃憖
Changelog updates
Changelog updates
Cross-platform user-facing changes
iOS user-facing changes
Android user-facing changes
Dev changes
Need help with something? Have a look at our docs, or get in touch with us.