Skip to content

Conversation

@Terracotta-6
Copy link
Contributor

Added an import tool for Kaleido format CSV files, file path: src/artisanlib/kaleido_csv_importer.py.

@AppVeyorBot
Copy link

Build artisan 8774178 (1779) failed (commit 87741784eb by @lxk36)

@MAKOMO
Copy link
Member

MAKOMO commented Jan 6, 2026

Thanks for this!

Could you please rework this a little?

  • remove the test change in the README.md
  • translate all comments to english
  • add test Kaleido csv files under src/test/sanity/data/kaleido/

I will then take it from there

@MAKOMO
Copy link
Member

MAKOMO commented Jan 6, 2026

It might also be a good idea to merge this code into src/artisanlib/kaleido.py instead of keeping this in a separate file not to have too many machine specific parts

@Terracotta-6
Copy link
Contributor Author

It might also be a good idea to merge this code into src/artisanlib/kaleido.py instead of keeping this in a separate file not to have too many machine specific parts
That’s a great idea! Merging the code into src/artisanlib/kaleido.py would help keep things organized and reduce fragmentation across machine-specific files. It’ll also make maintenance and future updates much easier.
The sampling cycle of the Kaleido industrial control screen is 1.5 seconds, and the ROR (Rate of Rise) is calculated based on C/30s. However, I suspect there might be an error in the ROR conversion. Could you please help verify it?

@Terracotta-6
Copy link
Contributor Author

Thanks for this!

Could you please rework this a little?

  • remove the test change in the README.md
  • translate all comments to english
  • add test Kaleido csv files under src/test/sanity/data/kaleido/

I will then take it from there

I’ve already made the requested changes:

Removed the test change from README.md
Translated all comments to English
Added the test Kaleido CSV files under src/test/sanity/data/kaleido/
Feel free to take it from here!

@AppVeyorBot
Copy link

@MAKOMO
Copy link
Member

MAKOMO commented Jan 6, 2026

Thanks! The test files are still missing. Please add them.

@AppVeyorBot
Copy link

@MAKOMO
Copy link
Member

MAKOMO commented Jan 7, 2026

Thanks, I take it from here!

@MAKOMO MAKOMO merged commit 57b1a34 into artisan-roaster-scope:master Jan 7, 2026
1 check was pending
@Terracotta-6 Terracotta-6 deleted the csv-import-kaleido branch January 7, 2026 09:52
@Terracotta-6 Terracotta-6 restored the csv-import-kaleido branch January 7, 2026 22:29
@Terracotta-6
Copy link
Contributor Author

Grateful to the Artisan team for merging PR #2090 (Kaleido CSV Importer). Thanks for the great collaboration!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants