Remove dependencies on arquillian-core testjars #286

[rhusar]

No description provided.

[WolfgangHG]

So you copied the arquillian base tests - same as I did locally to verify that they work ;-).

Could we keep this pull request on hold or even close it? Then I would apply the same change to my junit5 branch. Otherwise I end up in merge hell...

[rhusar]

Uh I just realized we don't have to change the class names, which makes the change even smaller and easily reversible (if we ever get to that point).

[rhusar]

So you copied the arquillian base tests - same as I did locally to verify that they work ;-).

Could we keep this pull request on hold or even close it? Then I would apply the same change to my junit5 branch. Otherwise I end up in merge hell...

If you did the same, then it will rebase cleanly. I did add documentation for each package.

Anyway, this is mergeable as is... but sure can keep this open.

[WolfgangHG]

I added your changes to my fork (converted to JUnit5): WolfgangHG@577736c

But before creating a pull request, I have to fix the mockito stubbing errors.

[WolfgangHG]

@rhusar I think we can close this one, as it is part of the JUnit migration?

[rhusar]

I did a rebase on this but it didn't rebase cleanly. I guess you changed the package names after all? My original idea was to keep the package names unchanged so we could theoretically then inherit the upstream test jar once it moves to junit5. But its a minor thing.

[WolfgangHG]

I think I also kept the original package names, e.g. https://github.com/arquillian/arquillian-extension-warp/blob/main/impl/src/test/java/org/jboss/arquillian/container/test/test/AbstractContainerTestTestBase.java
Or did I miss something?