feat: Added option for sticky display of variants panel with a single click #2554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnog
requested changes
Nov 27, 2024
| @@ -1135,19 +1135,21 @@ function handlePointerDown(ev: PointerEvent) { | |||
| } | |||
|
|
|||
| if (keycap.variants) { | |||
| if (pressAndHoldTimer) clearTimeout(pressAndHoldTimer); | |||
There was a problem hiding this comment.
Could you explain why clearing the timer had to be removed?
There was a problem hiding this comment.
It seems like I mistakenly removed it, so I’ll restore it.
src/public/virtual-keyboard.ts
Outdated
| @@ -98,6 +98,9 @@ export interface VirtualKeyboardKeycap { | |||
|
|
|||
| /** Name of the layer to shift to when the key is pressed */ | |||
| layer: string; | |||
|
|
|||
| /** Open variants panel without long press and does not close automatically */ | |||
| popover: boolean; | |||
There was a problem hiding this comment.
I would probably go with something a bit more descriptive. Maybe stickyVariantPanel?
There was a problem hiding this comment.
That's a good name.
konbu310
changed the title
konbu310
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #2549
Overview
This PR adds a
stickyVariantPaneloption to the VirtualKeyboardKeycap. When this option is enabled, clicking on a key with variants configured will display the Variants Panel without a long press. Additionally, the panel will not automatically hide.The motivation for implementing this feature is described in #2549, and a similar request can be found in #2363.
Notes