JNEW-RUNTIME-CLASS: support passing and returning doubles in methods #694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like a solid commit! I'm going test a little more with some things I have locally for inclusion in the long overdue abcl-1.9.3, but from what I can tell this is first-class contribution. Thanks! Edit: how would you like to be credited? As 'StrmSrfr' or something else? cheeers! |
|
"Samuel Edwin Ward" for the credits, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I followed the instructions in https://abcl.org/contributing.shtml:
ant test.ansi.interpreted:
58 failures with 58 unexpected failures and 0 unexpected successes out of 21911 tests.ant test.ansi.compiled:
63 failures with 63 unexpected failures and 0 unexpected successes out of 21911 tests.both before and after.
I also ran ant test.abcl:
20 out of 621 total tests failedafter (it was 620 before).
I'm happy to make any changes you recommend. Thanks!