Explorations in adding atomic compare and swap #602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VarHandles were introduced in openjdk9, so the code needs to be conditionalized somehow. It is currently being developed on openjdk17. <armedbear#92>
|
is there anything blocking this? maybe this can be added as a package and throw an error on load if jdk is detected as lower than 9? |
|
Not sure this code really does what we want for CAS, so at a minimum we should develop some tests. As for conditionalizing the load we need a proposed implementation that is also tested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VarHandles were introduced in openjdk9, so the code needs to be conditionalized somehow. It is currently being developed on openjdk17.
#92