Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete Watch endpoint #3913

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions client/DotNet/ArmadaProject.Io.Client.Test/Tests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -29,12 +29,13 @@ public async Task TestSimpleJobSubmitFlow()

//watch events
var eventClient = new ApiEvent.EventClient(channel);
var watchRequest = new WatchRequest
var watchRequest = new JobSetRequest
{
Queue = queue,
JobSetId = jobSetId
Id = jobSetId,
Watch = true,
};
var watchResponse = eventClient.Watch(watchRequest);
var watchResponse = eventClient.GetJobSetEvents(watchRequest);
var submittedEventReceived = false;
using (var cts = new CancellationTokenSource())
{
Expand Down Expand Up @@ -98,4 +99,4 @@ private static JobSubmitRequest CreateSubmitRequest(string queue, string jobSetI
return request;
}
}
}
}
11 changes: 0 additions & 11 deletions internal/server/event/event.go
Original file line number Diff line number Diff line change
Expand Up @@ -71,17 +71,6 @@ func (s *EventServer) Health(_ context.Context, _ *types.Empty) (*api.HealthChec
return &api.HealthCheckResponse{Status: api.HealthCheckResponse_SERVING}, nil
}

func (s *EventServer) Watch(req *api.WatchRequest, stream api.Event_WatchServer) error {
request := &api.JobSetRequest{
Id: req.JobSetId,
Watch: true,
FromMessageId: req.FromId,
Queue: req.Queue,
ErrorIfMissing: true,
}
return s.GetJobSetEvents(request, stream)
}

func (s *EventServer) serveEventsFromRepository(request *api.JobSetRequest, eventRepository EventRepository,
stream api.Event_GetJobSetEventsServer,
) error {
Expand Down
Loading