Fix typing on listener #14
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This failed because "the build image for this site uses Ubuntu 14.04 Trusty Tahr, which is no longer supported." |
|
Yes, the CI updates the docs. Will fix, thanks for the PR |
|
Please rebase on master which should be capable of building the docs |
mardiros
force-pushed
the
features/fix-type
branch
from
c72e3f2
to
459f028
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am currently implementing a listener of the circuitbreaker, but actually, received object does not match the declared typed.
https://github.com/mardiros/blacksmith/blob/master/src/blacksmith/middleware/circuit_breaker.py#L48-L66