[WIP]Indexer #524
[WIP]Indexer #524
Conversation
| func (i *indexerService) GetCommitmentTxInfo( | ||
| ctx context.Context, txid string, | ||
| ) (*CommitmentTxResp, error) { | ||
| round, err := i.repoManager.Rounds().GetRoundWithTxid(ctx, txid) |
There was a problem hiding this comment.
This API can take time if the database and the round are big, we should use an ad hoc api that basically returns the data as defined in the proto.
| } | ||
|
|
||
| func (i *indexerService) GetForfeitTxs(ctx context.Context, req ForfeitTxsReq) (*ForfeitTxsResp, error) { | ||
| round, err := i.repoManager.Rounds().GetRoundWithTxid(ctx, req.BatchOutpoint.Txid) //TODO batch thing |
There was a problem hiding this comment.
let's make use of an ad hoc API GetRoundForfeitTxs that returns only the list of forfeit txids for a given round txid
| } | ||
|
|
||
| func (i *indexerService) GetConnectors(ctx context.Context, req ConnectorsReq) (*ConnectorResp, error) { | ||
| round, err := i.repoManager.Rounds().GetRoundWithTxid(ctx, req.BatchOutpoint.Txid) //TODO batch thing |
There was a problem hiding this comment.
same here, we can make use of an ad hoc GetRoundConnectorTree
| } | ||
|
|
||
| func (i *indexerService) GetTransactionHistory(ctx context.Context, req TxHistoryReq) (*TxHistoryResp, error) { | ||
| allVtxos, err := i.repoManager.Vtxos().GetAll(ctx) |
There was a problem hiding this comment.
let's make use of an ad hoc API GetVtxosWithPubKey instead of getting the whole vtxo set and then filter by pubkey. The code to extract the pubkey from the address can be taken from the func above
| @@ -140,3 +140,142 @@ type TxRequestInfo struct { | |||
| Cosigners []string | |||
| LastPing time.Time | |||
| } | |||
|
|
|||
| type VtxoTreeReq struct { | |||
There was a problem hiding this comment.
can we please drop all these *Req structs? I'm ok with the resp ones, but anyway, this indexer will stay here only for a bit hopefully... let's have the less possible impact in terms of changes to existing files.
| } | ||
|
|
||
| func (i *indexerService) GetVirtualTxs(ctx context.Context, req VirtualTxsReq) (*VirtualTxsResp, error) { | ||
| vtxos, err := i.repoManager.Vtxos().GetAll(ctx) |
There was a problem hiding this comment.
let's make use of the newly defined API GetTxsWithTxids.
This implements rpc’s from indexer.proto and adds those methods to sdk client(grpc/rest)
@altafan please review.