Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uno preset #423

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

uno preset #423

wants to merge 2 commits into from

Conversation

jeffposnick
Copy link

This is a work-in-progress PR, which fixes #406

I learned a lot about how to translate CSS variables into something that could be effectively applied as a style by a framework like https://unocss.dev/

I need to take a look at what other themes and rules it would make sense to define as part of this preset.

As it stands, you can apply styles that use the font and color variables via class names like op-font-sans or op-color-choco-4.

@stackblitz
Copy link

stackblitz bot commented Sep 29, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

import Colors from "../../../src/props.colors.js";
import Fonts from "../../../src/props.fonts.js";

export const openPropsPreset = {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sick, do the work in the module export with the js source files, very nice! much better than a build file's output

@argyleink argyleink marked this pull request as draft September 29, 2023 21:44
@argyleink argyleink changed the title [Draft]: uno preset uno preset Sep 29, 2023
@bjorntheart
Copy link
Contributor

@jeffposnick Are you still working on this? I Would love to help. I'm doing something similar, but would rather focus my efforts here and contribute.

@jeffposnick
Copy link
Author

Sorry, no, I haven't been able to devote the time to wrapping this up. Feel free to take over and reuse anything that's useful!

@bjorntheart
Copy link
Contributor

Thanks @jeffposnick.

@argyleink I'm taking over from @jeffposnick on this one. What's the best approach to go about this, create a brand new PR, and mention this one for context?

@argyleink
Copy link
Owner

I think you could PR his PR, so then he gets contributor status when it all merges? But maybe that puts a bit of work on @jeffposnick that they don't want? I can also help make @jeffposnick a contributor in an easy way after a pr merges that resolves the feature.

I'm good either way! Just wanna make sure folks get their cred

@bjorntheart
Copy link
Contributor

I'm good either way! Just wanna make sure folks get their cred

Agreed!

@argyleink Think I'm going to make a new PR for this one ;-)

@bjorntheart bjorntheart mentioned this pull request Feb 12, 2024
@jeffposnick
Copy link
Author

I'm good either way! Whatever is easiest for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adapter for Uno
3 participants