Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: include color helper #355

Merged
merged 3 commits into from
Mar 17, 2023
Merged

Conversation

kaf-lamed-beyt
Copy link
Contributor

#354

Hi @argyleink, kindly take a look.

@stackblitz
Copy link

stackblitz bot commented Mar 17, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Owner

@argyleink argyleink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Can you update a style too, so it aligns better on desktop? Here's what needs changed.

footer dl > div {
  place-self: start center;
}

@kaf-lamed-beyt
Copy link
Contributor Author

Can you update a style too, so it aligns better on desktop? Here's what needs changed.

All done.

Learned something new today, because this is the first time I'm seeing this particular CSS property — place-self

Thank you for the opportunity, @argyleink!

Comment on lines 172 to 175
footer dl > div {
place-self: start center;
}

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you change it here instead please =)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a guess about this too. I'll change it now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Owner

@argyleink argyleink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty! 💯

@argyleink argyleink merged commit 02c92d4 into argyleink:main Mar 17, 2023
@kaf-lamed-beyt
Copy link
Contributor Author

🫡

saitheninja pushed a commit to saitheninja/open-props that referenced this pull request Apr 29, 2023
* chore: include color helper

* chore: adjust layout

* minor
saitheninja pushed a commit to saitheninja/open-props that referenced this pull request Apr 29, 2023
* chore: include color helper

* chore: adjust layout

* minor
saitheninja added a commit to saitheninja/open-props that referenced this pull request Apr 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants