Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 192 #194

Closed
wants to merge 11 commits into from
Closed

Issue 192 #194

wants to merge 11 commits into from

Conversation

Que-tin
Copy link
Contributor

@Que-tin Que-tin commented Feb 17, 2022

No description provided.

Fix build on windows devices by manually setting undefined for a not defined prefix.
Copy link
Owner

@argyleink argyleink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well this turned out to be a bit more than anticipated! cool news is I think this is really going to up the bar for animation libraries and reduced motion, thanks so much for kicking this off.

there's comments all over the place, mostly me realizing stuff and offering some code suggestions. 11 comments sounds like a lot lol, but i think it'll go quick! 🙏🏻

here's all of them turned on, aka showing them in their worst light but also an overview

Kapture.2022-02-22.at.22.17.39.mp4

src/props.animations.js Outdated Show resolved Hide resolved
src/props.animations.js Outdated Show resolved Hide resolved
src/props.animations.js Outdated Show resolved Hide resolved
src/props.animations.js Outdated Show resolved Hide resolved
src/props.animations.js Outdated Show resolved Hide resolved
src/props.animations.js Outdated Show resolved Hide resolved
src/props.animations.js Outdated Show resolved Hide resolved
src/props.animations.js Outdated Show resolved Hide resolved
src/props.animations.js Outdated Show resolved Hide resolved
build/props.js Outdated Show resolved Hide resolved
@argyleink argyleink added the enhancement New feature or request label Feb 23, 2022
@argyleink argyleink linked an issue Feb 23, 2022 that may be closed by this pull request
@Que-tin
Copy link
Contributor Author

Que-tin commented Feb 23, 2022

Done. Somone needs to check the reduced motion timings. Especially shake & bounce are behaving a bit weird.

@argyleink
Copy link
Owner

did some polish and fixed an animation, made a PR to your branch! https://github.com/Que-tin/open-props/pull/1

adds fixes/docs for combo examples, fixes scale animations
@Que-tin
Copy link
Contributor Author

Que-tin commented Feb 24, 2022

@argyleink Checked and tested everything, looks good to me 👍🏻😊

Your PR also got merged.

@argyleink
Copy link
Owner

Next step is I'll host the feature and send it to a few folks I trust and who prefer reduced motion, have them test it and give it some QA 👍🏻

@argyleink
Copy link
Owner

@argyleink
Copy link
Owner

review #1:

I agree but I can only speak for myself: most of the time I'm okay with small animations (like color fade), it's mostly paralax and things moving around too much that trigger me ^^
And spinning hahaha spinning is NOOOO good for my brain 😄
haa the spining even with motion reduced is a big NOPE hahaa
The step by step animations feel strange without transition, to be honnest. It's a little bit hard to give you feedback since it also depends on how those are used in a page
The bounce is also a big nope at the moment even in the reduce motion, but the pulse is okay. So I think it's the size of the change and the speed as well that impacts
but again, it might depend on the level of sensitivity to motion sickness

@argyleink
Copy link
Owner

i still think about these efforts and where they should go 🙂

@Que-tin
Copy link
Contributor Author

Que-tin commented Apr 28, 2023

Closed due to the progress pn #341

@Que-tin Que-tin deleted the Issue-192 branch April 28, 2023 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reduced motion by default for Animations
2 participants