Validate Unicode direction override markers in documentation comments - #16812
Open
msooseth wants to merge 4 commits into
Open
Validate Unicode direction override markers in documentation comments#16812msooseth wants to merge 4 commits into
msooseth wants to merge 4 commits into
Conversation
Update changelog More const Less const Less const Update const
Contributor
|
@msooseth, can you link to the issue this is fixing? |
Contributor
Author
|
This is trying to fix an issue that our LLM skill discovered regarding parsing of comments. I tried reviewing it and making it sane. There is no issue that I filed but the test cases are showing where things would go wrong. |
Comment on lines
+4
to
+5
| /// underflow |
Contributor
There was a problem hiding this comment.
Can you add a multiline comment test case, for each of these (// and ///) where you open an override on one line and close it on the next?
|
|
||
| Bugfixes: | ||
| * NatSpec: Disallow `@return` tag in event documentation. | ||
| * Parser: Detect unbalanced Unicode direction override markers (e.g. `U+202E`) in documentation comments (`///` and `/** */`) |
Contributor
There was a problem hiding this comment.
Suggested change
| * Parser: Detect unbalanced Unicode direction override markers (e.g. `U+202E`) in documentation comments (`///` and `/** */`) | |
| * Scanner: Detect unbalanced Unicode direction override markers (e.g. `U+202E`) in documentation comments (`///` and `/** */`) |
Comment on lines
+4
to
+5
| /// underflow |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I tried to make this MINIMAL and SANE and SIMPLE. I really hope this can be reviewed within reasonable time.
Checklist
AI Disclosure
An AI tool discovered it, and proposed a solution, I reviewed it and updated it, and reviewed it again.