feat: support filter node type in retry expression. Fixes: #13990

[shuangkun]

I hope to configure the global retryStrategy uniformly, but I don't want the Step/DAG type retry to cause the task to be re-run.

#13990 (comment)

Fixes #13990

Motivation

Modifications

Verification

UT and Local test
For Workflow

apiVersion: argoproj.io/v1alpha1
kind: Workflow
metadata:
  generateName: test01-fail-
spec:
  entrypoint: step-entrypoint
  templates:
  - name: step-entrypoint
    steps:
    - - name: step-a
        template: a
    - - name: step-b
        template: dag-b

  - name: dag-b
    dag:
      tasks:
      - name: dag-b
        template: b

  - name: a
    container:
      image: busybox:latest
      command: [sh, -c]
      args: ["echo a step && sleep 5"]

  - name: b
    container:
      image: busybox:latest
      command: [sh, -c]
      args: ["echo b step && sleep 5 && exit 1"]

template b always failed.

With global RetryStrategy in workflow-controller-configmap:

        retryStrategy:
          limit: 4

After add the feature, and with global RetryStrategy in workflow-controller-configmap:

        retryStrategy:
          limit: 4
          expression: "retry.nodeType == 'Pod'"

Documentation

add "retry.nodeType" in docs/retries.md and docs/variables.md

[shuangkun]

/retest

[shuangkun]

/retest

[shuangkun]

/retest

[tczhao]

I'm thinking if we should have node.type available to all template instead of adding it in the retryexpression

instead of having it only available to retry strategy.

node.type naturally aligns with the current variable names and we don't need to introduce additional retry.variable