Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: build argoexec on windows 2022 & 2025 #14179

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

mweibel
Copy link
Contributor

@mweibel mweibel commented Feb 11, 2025

Motivation

New major windows version is out and we'll be testing the version soon.

Modifications

Adjusted release build to build on windows 2022 and windows 2025 while also adjusting the generated manifest.

Verification

Couldn't test it since it's a GitHub runner adjustment.

@mweibel mweibel marked this pull request as ready for review February 11, 2025 08:41
@mweibel
Copy link
Contributor Author

mweibel commented Feb 11, 2025

should I, as a test, adjust the rules when to build the pipeline or do you have already an established way in place to test changes to github workflows?

@tico24
Copy link
Member

tico24 commented Feb 11, 2025

It would be more common to adjust on your fork to test so that you can demonstrate it works.

@mweibel
Copy link
Contributor Author

mweibel commented Feb 13, 2025

@tico24 I adjusted the workflow so it can run - the build was successful but due to missing secrets I of course couldn't push the image.

https://github.com/helio/argo-workflows/actions/runs/13303462419/job/37149113756

does that suffice?
Otherwise I could probably rename the branch to start with dev-* and it would run the workflow here, too. Would you prefer that?

@mweibel
Copy link
Contributor Author

mweibel commented Feb 14, 2025

oh, I'm sorry. I just saw something upon doing a deeper inspection. Need to verify it actually works.

indeed - latest build fails: https://github.com/helio/argo-workflows/actions/runs/13329479489/job/37230045905
we've had similar issues just today with other docker images. Might have to do with the windows revision. Will clarify this and possibly update what is needed.

@mweibel mweibel marked this pull request as draft February 14, 2025 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants