build: optimize Makefile and fix infinite loop

[MasonM]

Motivation

This makes some improvements to the Makefile to speed up local development and avoid a common race condition when building.

Modifications

1. Remove DOCKER_DESKTOP because nothing uses it

2. Set GOPATH as a simply expanded variable so go env GOPATH isn't executed multiple times

3. Don't run the commands associated with the ARGOEXEC_PKG_FILES/CLI_PKG_FILES/CONTROLLER_PKG_FILES variables unless the target(s) needs them, because they're very slow. This speeds up make by ~1.5s for me. Before.

   $ time make check-pwd 
   GIT_COMMIT=f796449df96888538af873bd6871374c2156db7b GIT_BRANCH=main GIT_TAG=untagged GIT_TREE_STATE=dirty RELEASE_TAG=false DEV_BRANCH=false VERSION=latest
   KUBECTX=k3d-k3s-default DOCKER_DESKTOP=false K3D=true DOCKER_PUSH=false TARGET_PLATFORM=linux/amd64 
   RUN_MODE=local PROFILE=minimal AUTH_MODE=hybrid SECURE=false  STATIC_FILES=true ALWAYS_OFFLOAD_NODE_STATUS=false UPPERIO_DB_DEBUG=0 LOG_LEVEL=debug NAMESPACED=true make: Nothing to be done for 'check-pwd'.
   
   real    0m1.764s
   user    0m4.382s
   sys     0m0.857s
   

   After:

   $ time make check-pwd
   GIT_COMMIT=f796449df96888538af873bd6871374c2156db7b GIT_BRANCH=main GIT_TAG=untagged GIT_TREE_STATE=dirty RELEASE_TAG=false DEV_BRANCH=false VERSION=latest
   KUBECTX=k3d-k3s-default K3D=true DOCKER_PUSH=false TARGET_PLATFORM=linux/amd64
   RUN_MODE=local PROFILE=minimal AUTH_MODE=hybrid SECURE=false  STATIC_FILES=true ALWAYS_OFFLOAD_NODE_STATUS=false UPPERIO_DB_DEBUG=0 LOG_LEVEL=debug NAMESPACED=true
   make: Nothing to be done for 'check-pwd'.
   
   real    0m0.117s
   user    0m0.060s
   sys     0m0.073s
   

4. Fix issue where pkg/apis/workflow/v1alpha1/zz_generated.deepcopy.go is deleted during a build and it causes Kit to enter an infinite loop. This is a race condition triggered when running something like kit pre-up. During that, as soon as util/telemetry/attributes.go is regenerated, this triggers Kit to abort the make ./dist/argo command. If that command is in the middle of regenerating pkg/apis/workflow/v1alpha1/zz_generated.deepcopy.go, then make deletes it:

   waiting for mutex "build"
   make: *** Deleting file 'pkg/apis/workflow/v1alpha1/zz_generated.deepcopy.go'
   make: *** [Makefile:657: pkg/apis/workflow/v1alpha1/zz_generated.deepcopy.go] Terminated
   signal: terminated
   

   This tells make not to delete it using the special .PRECIOUS target.

Verification

Ran kit pre-up and a bunch of other commands

[terrytangyuan]

Thanks. This should be fine as long as the build passes