Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(metricprovider): add support for specifying a datasource for a given query #3560

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

backjo
Copy link
Contributor

@backjo backjo commented May 7, 2024

Closes #2628

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

Copy link
Contributor

github-actions bot commented May 7, 2024

Go Published Test Results

2 160 tests   2 160 ✅  2m 53s ⏱️
  119 suites      0 💤
    1 files        0 ❌

Results for commit b0bc0bf.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented May 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.20%. Comparing base (8405f2e) to head (b0bc0bf).
Report is 102 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3560      +/-   ##
==========================================
- Coverage   81.83%   78.20%   -3.64%     
==========================================
  Files         135      158      +23     
  Lines       20688    18402    -2286     
==========================================
- Hits        16931    14391    -2540     
- Misses       2883     3104     +221     
- Partials      874      907      +33     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented May 8, 2024

E2E Tests Published Test Results

  4 files    4 suites   3h 31m 29s ⏱️
110 tests  96 ✅  6 💤  8 ❌
464 runs  416 ✅ 24 💤 24 ❌

For more details on these failures, see this check.

Results for commit b0bc0bf.

♻️ This comment has been updated with latest results.

backjo added 4 commits May 7, 2024 19:24
Signed-off-by: Jonah Back <[email protected]>
Signed-off-by: Jonah Back <[email protected]>
Signed-off-by: Jonah Back <[email protected]>
Signed-off-by: Jonah Back <[email protected]>
Copy link

sonarcloud bot commented May 9, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
6.5% Duplication on New Code

See analysis details on SonarCloud

Signed-off-by: Jonah Back <[email protected]>
@backjo backjo marked this pull request as ready for review May 10, 2024 05:42
@zachaller zachaller added this to the v1.8 milestone May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't query datadog logs using analysis template
2 participants