Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(experiments): add ability to set service port mappings #3544

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

yohanb
Copy link
Contributor

@yohanb yohanb commented Apr 29, 2024

Adds enhancement #3428

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

Copy link
Contributor

github-actions bot commented Apr 29, 2024

Go Published Test Results

2 160 tests   2 160 ✅  2m 53s ⏱️
  119 suites      0 💤
    1 files        0 ❌

Results for commit 4a99969.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Apr 29, 2024

E2E Tests Published Test Results

  4 files    4 suites   3h 29m 2s ⏱️
111 tests  98 ✅  6 💤  7 ❌
458 runs  420 ✅ 24 💤 14 ❌

For more details on these failures, see this check.

Results for commit 4a99969.

♻️ This comment has been updated with latest results.

@yohanb yohanb force-pushed the feat_experiment_port_mappings branch 2 times, most recently from 9f31bbd to ed8aa29 Compare April 29, 2024 17:08
Copy link

codecov bot commented Apr 29, 2024

Codecov Report

Attention: Patch coverage is 81.25000% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 78.18%. Comparing base (8405f2e) to head (4a99969).
Report is 102 commits behind head on master.

Files Patch % Lines
experiments/experiment.go 85.18% 3 Missing and 1 partial ⚠️
rollout/experiment.go 60.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3544      +/-   ##
==========================================
- Coverage   81.83%   78.18%   -3.66%     
==========================================
  Files         135      158      +23     
  Lines       20688    18414    -2274     
==========================================
- Hits        16931    14397    -2534     
- Misses       2883     3108     +225     
- Partials      874      909      +35     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yohanb yohanb force-pushed the feat_experiment_port_mappings branch from ed8aa29 to 74a6051 Compare April 29, 2024 17:14
@yohanb
Copy link
Contributor Author

yohanb commented Apr 30, 2024

Codecov Report

Attention: Patch coverage is 81.25000% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 78.20%. Comparing base (8405f2e) to head (74a6051).
Report is 99 commits behind head on master.

Files Patch % Lines
experiments/experiment.go 85.18% 3 Missing and 1 partial ⚠️
rollout/experiment.go 60.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3544      +/-   ##
==========================================
- Coverage   81.83%   78.20%   -3.64%     
==========================================
  Files         135      158      +23     
  Lines       20688    18414    -2274     
==========================================
- Hits        16931    14400    -2531     
- Misses       2883     3105     +222     
- Partials      874      909      +35     

☔ View full report in Codecov by Sentry. 📢 Have feedback on the report? Share it here.

👋 @zachaller not sure why the code coverage dropped. I added an e2e test that covers the new code paths 🤔

Copy link

sonarcloud bot commented May 7, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant