Skip to content

Commit

Permalink
Add service reconcile in case of still ref rs
Browse files Browse the repository at this point in the history
  • Loading branch information
BrunoTarijon committed Feb 29, 2024
1 parent 1099f88 commit 8a35ef7
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions rollout/canary.go
Original file line number Diff line number Diff line change
Expand Up @@ -187,6 +187,7 @@ func (c *rolloutContext) scaleDownOldReplicaSetsForCanary(oldRSs []*appsv1.Repli
if c.rollout.Spec.Strategy.Canary.TrafficRouting != nil && c.isReplicaSetReferenced(targetRS) {
// We might get here if user interrupted an an update in order to move back to stable.
c.log.Infof("Skip scale down of older RS '%s': still referenced", targetRS.Name)
c.reconcileStableAndCanaryService()

Check failure on line 190 in rollout/canary.go

View workflow job for this annotation

GitHub Actions / Lint Go code

File is not `gofmt`-ed with `-s` (gofmt)
continue
}
if maxScaleDown <= 0 {
Expand Down

0 comments on commit 8a35ef7

Please sign in to comment.