Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(server): Fix server crash due to race condition in go-redis triggered by DNS instability #22251

Open
wants to merge 1 commit into
base: release-2.13
Choose a base branch
from

Conversation

anandf
Copy link
Contributor

@anandf anandf commented Mar 7, 2025

Fixes #20824

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@anandf anandf requested review from a team as code owners March 7, 2025 19:04
Copy link

bunnyshell bot commented Mar 7, 2025

✅ Preview Environment deployed on Bunnyshell

Component Endpoints
argocd https://argocd-kurpor.bunnyenv.com/
argocd-ttyd https://argocd-web-cli-kurpor.bunnyenv.com/

See: Environment Details | Pipeline Logs

Available commands (reply to this comment):

  • 🔴 /bns:stop to stop the environment
  • 🚀 /bns:deploy to redeploy the environment
  • /bns:delete to remove the environment

@anandf anandf changed the base branch from master to release-2.13 March 7, 2025 19:05
@anandf anandf force-pushed the fix_server_crash_goredis branch from 8c9e244 to b5e44a1 Compare March 7, 2025 19:34
@anandf anandf changed the title fix(server): Fix server crash due to race condition in go-redis client library triggered by DNS instability fix(server): Fix server crash due to race condition in go-redis triggered by DNS instability Mar 8, 2025
@anandf anandf requested a review from a team as a code owner March 8, 2025 06:52
Copy link

codecov bot commented Mar 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.03%. Comparing base (180d689) to head (04239fa).

Additional details and impacted files
@@               Coverage Diff                @@
##           release-2.13   #22251      +/-   ##
================================================
- Coverage         55.09%   55.03%   -0.06%     
================================================
  Files               320      320              
  Lines             54852    54852              
================================================
- Hits              30221    30189      -32     
- Misses            22046    22069      +23     
- Partials           2585     2594       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anandf anandf force-pushed the fix_server_crash_goredis branch from 6543f9a to 04239fa Compare March 8, 2025 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Redis issue on argocd-application-controller v2.13.0, chart 7.7.3
1 participant